Skip to content

Fixed documentation example for responseType #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Giotino merged 1 commit into from
Oct 8, 2020
Merged

Fixed documentation example for responseType #1494

Giotino merged 1 commit into from
Oct 8, 2020

Conversation

@feyzullahyildiz
Copy link
Contributor

@feyzullahyildiz feyzullahyildiz commented Oct 8, 2020

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

@Giotino Giotino changed the title readme js code fix Fixed documentation example for responseType Oct 8, 2020
@Giotino Giotino merged commit 87dadd5 into sindresorhus:master Oct 8, 2020
@sindresorhus
Copy link
Owner

sindresorhus commented Oct 8, 2020

@Giotino Just a tiny note. We use present tense for commit messages (this is the most common style). So Fix instead of Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Giotino Giotino Giotino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@feyzullahyildiz @sindresorhus @Giotino