Clear the progress interval if the socket has been destroyed (#469)

AsaAyers · sindresorhus · commit 82763c808959 · 2018-05-01T14:02:54.000+07:00
diff --git a/index.js b/index.js
@@ -198,6 +198,11 @@ function requestAsEventEmitter(opts) {
 						const uploadEventFrequency = 150;
 
 						progressInterval = setInterval(() => {
+							if (socket.destroyed) {
+								clearInterval(progressInterval);
+								return;
+							}
+
 							const lastUploaded = uploaded;
 							const headersSize = Buffer.byteLength(req._header);
 							uploaded = socket.bytesWritten - headersSize;
diff --git a/test/socket-destroyed.js b/test/socket-destroyed.js
@@ -0,0 +1,9 @@
+import test from 'ava';
+import got from '..';
+
+test.serial('clear the progressInterval if the socket has been destroyed', async t => {
+	const handlesComingFromAVA = 2;
+	const err = await t.throws(got(`http://127.0.0.1:55555`, {retry: 0}));
+	t.is(process._getActiveHandles().length - handlesComingFromAVA, 2);
+	t.is(err.code, 'ECONNREFUSED');
+});
