Skip to content

Commit 33cbb6f

Browse files
committed
Make the useElectron option false by default
Fixes #359 Related to #315 `electron.net` is just too buggy.
1 parent b55f79e commit 33cbb6f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ function normalizeArguments(url, opts) {
435435
path: '',
436436
retries: 2,
437437
decompress: true,
438-
useElectronNet: true
438+
useElectronNet: false
439439
},
440440
url,
441441
{

readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,9 +173,9 @@ If this is disabled, a compressed response is returned as a `Buffer`. This may b
173173
###### useElectronNet
174174

175175
Type: `boolean`<br>
176-
Default: `true`
176+
Default: `false`
177177

178-
When used in Electron, Got will automatically use [`electron.net`](https://electron.atom.io/docs/api/net/) instead of the Node.js `http` module. It should be fully compatible, but you can turn it off here if you encounter a problem. Please open an issue if you do!
178+
When used in Electron, Got will use [`electron.net`](https://electron.atom.io/docs/api/net/) instead of the Node.js `http` module. According to the Electron docs, it should be fully compatible, but it's not entirely. See [#315](https://github.com/sindresorhus/got/issues/315).
179179

180180

181181
#### Streams

0 commit comments

Comments
 (0)