Fix default pagination handling for empty Link header (#1768)

joshua-leyshon-canva · sindresorhus · web-flow · commit 1e1e50647e93 · 2021-07-01T12:07:28.000+07:00
Co-authored-by: Sindre Sorhus &lt;sindresorhus@gmail.com&gt;
diff --git a/source/core/options.ts b/source/core/options.ts
@@ -674,11 +674,12 @@ const defaultInternals: Options['_internals'] = {
 			return JSON.parse(response.body as string);
 		},
 		paginate: ({response}) => {
-			if (typeof response.headers.link !== 'string') {
+			const rawLinkHeader = response.headers.link;
+			if (typeof rawLinkHeader !== 'string' || rawLinkHeader.trim() === '') {
 				return false;
 			}
 
-			const parsed = parseLinkHeader(response.headers.link);
+			const parsed = parseLinkHeader(rawLinkHeader);
 			const next = parsed.find(entry => entry.parameters.rel === 'next' || entry.parameters.rel === '"next"');
 
 			if (next) {
diff --git a/test/pagination.ts b/test/pagination.ts
@@ -43,6 +43,18 @@ test('the link header has no next value', withServer, async (t, server, got) =>
 	t.deepEqual(received, items);
 });
 
+test('the link header is empty', withServer, async (t, server, got) => {
+	const items = [1];
+
+	server.get('/', (_request, response) => {
+		response.setHeader('link', '');
+		response.end(JSON.stringify(items));
+	});
+
+	const received = await got.paginate.all<number>('');
+	t.deepEqual(received, items);
+});
+
 test('retrieves all elements', withServer, async (t, server, got) => {
 	attachHandler(server, 2);
 
