Allow specifying undefined for options (#2258)

WillianAgostini · web-flow · commit 1cefe8bb00c9 · 2023-05-27T21:12:03.000+07:00
diff --git a/source/core/options.ts b/source/core/options.ts
@@ -1078,7 +1078,13 @@ export default class Options {
 				}
 
 				// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
-				this[key as keyof Options] = options[key as keyof Options];
+				const value = options[key as keyof Options];
+				if (value === undefined) {
+					continue;
+				}
+
+				// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
+				this[key as keyof Options] = value;
 
 				push = true;
 			}
diff --git a/test/agent.ts b/test/agent.ts
@@ -205,3 +205,17 @@ test('no socket hung up regression', withServer, async (t, server, got) => {
 
 	agent.destroy();
 });
+
+test('accept undefined agent', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.end('ok');
+	});
+
+	const undefinedAgent = undefined;
+	t.truthy((await got({
+		https: {
+			rejectUnauthorized: false,
+		},
+		agent: undefinedAgent,
+	})).body);
+});

Original file line number	Diff line number	Diff line change
`@@ -1078,7 +1078,13 @@ export default class Options {`
`1078`	`1078`	`}`
`1079`	`1079`
`1080`	`1080`	`// @ts-expect-error Type 'unknown' is not assignable to type 'never'.`
`1081`		`- this[key as keyof Options] = options[key as keyof Options];`
	`1081`	`+ const value = options[key as keyof Options];`
	`1082`	`+ if (value === undefined) {`
	`1083`	`+ continue;`
	`1084`	`+ }`
	`1085`	`+`
	`1086`	`+ // @ts-expect-error Type 'unknown' is not assignable to type 'never'.`
	`1087`	`+ this[key as keyof Options] = value;`
`1082`	`1088`
`1083`	`1089`	`push = true;`
`1084`	`1090`	`}`