Add UTF-16 (BE and LE) string compare#764
Merged
sindresorhus merged 4 commits intomainfrom Jun 10, 2025
Merged
Conversation
- Correct BE/LE code BOM code comments - Increase initial buffer size from 12 to 32 bytes - Increase signature length with 2 byte (space) in BOM UTF-16 prefixed XML files
Borewit
force-pushed
the
utf16-string-compare
branch
from
5f29161 to
eecd14e
Compare
sindresorhus
requested changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add internal support to compare UTF16-BE and UTF16-LE strings.
Reason I added this, is because I want to follow up with support Windows registry change files, which are prefixed with
Windows Registry Editor Version 5.00, in a UTF16-LE encoded, BOM prefixed text file.Keeps the code more compact and readable, if we use the actual strings we are comparing.