Skip to content

Conversation

@sergiou87
Copy link
Contributor

While working on bringing full arm64 (Apple Silicon) support to https://github.com/desktop/desktop, I noticed app-path had its own prebuilt binary for x86_64.

This PR adds compile- scripts to build main for both x86_64 and arm64 platforms, and replaces the previous compile script with one that invokes the other two compile- and lipos the resulting binaries into a universal binary:

$ file main
main: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]
main (for architecture x86_64):	Mach-O 64-bit executable x86_64
main (for architecture arm64):	Mach-O 64-bit executable arm64

@sindresorhus sindresorhus merged commit 7e6082a into sindresorhus:main Apr 29, 2021
@sindresorhus
Copy link
Owner

Thanks :)

@sergiou87
Copy link
Contributor Author

I forgot to say that if this PR gets the 👍  and is merged, I'd appreciate if we could get a release with it 😄

@sergiou87
Copy link
Contributor Author

Wow that was fast!! Thank you!! ❤️

@sindresorhus
Copy link
Owner

@sergiou87
Copy link
Contributor Author

You are the best, thank you!!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants