Revert "PATH_INFO can never be empty."#2124
Merged
dentarg merged 1 commit intosinatra:mainfrom Oct 10, 2025
Merged
Conversation
This reverts commit fa99a21. It causes problems, if you have an app like this class FooApp < Sinatra::Base get "/" do "hello foo" end end and map it like this in config.ru map("/foo") { run FooApp.new } GET /foo returns 404, which was not the case before. GET /foo/ does reach the app.
dentarg
changed the title
PATH_INFO can never be empty. (#2114)"PATH_INFO can never be empty."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fa99a21.
It causes problems, if you have an app like this
and map it like this in config.ru
GET /fooreturns 404, which was not the case before.GET /foo/does reach the app.Reported at #2113 (comment)