Skip to content

Fix regex in etag_matches? to prevent ReDoS#2121

Merged
dentarg merged 1 commit intosinatra:mainfrom
gecunps:main
Oct 8, 2025
Merged

Fix regex in etag_matches? to prevent ReDoS#2121
dentarg merged 1 commit intosinatra:mainfrom
gecunps:main

Conversation

@gecunps
Copy link
Copy Markdown
Contributor

@gecunps gecunps commented Oct 8, 2025 •
edited by dentarg
Loading

@dentarg dentarg changed the title Fix regex to prevent redos Fix regex in etag_matches? to prevent ReDoS Oct 8, 2025
@dentarg dentarg merged commit 3fe8c38 into sinatra:main Oct 8, 2025
28 checks passed
@dentarg
Copy link
Copy Markdown
Member

dentarg commented Oct 8, 2025

Please report issues like this privately in the future: https://github.com/sinatra/sinatra/blob/main/SECURITY.md

@github-actions github-actions bot mentioned this pull request Nov 3, 2025
Closed
@ghost
Copy link
Copy Markdown

ghost commented Jan 25, 2026

#2120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dentarg dentarg dentarg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement suggestion

2 participants

@gecunps @dentarg