Fix #1487 update test and docs to support erubi #1494
Merged
+36
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkmru
changed the title
tkmru
changed the title
Contributor
Author
|
@namusyaka I fixed them. |
namusyaka
approved these changes
Dec 8, 2018
Member
namusyaka
left a comment
namusyaka
left a comment
There was a problem hiding this comment.
Sorry for the delay, but looks good to me. Thanks for your contribution!
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 6, 2019
## 2.0.5 / 2018-12-22 * Avoid FrozenError when params contains frozen value [#1506](sinatra/sinatra#1506) by Kunpei Sakai * Add support for Erubi [#1494](sinatra/sinatra#1494) by @tkmru * `IndifferentHash` monkeypatch warning improvements [#1477](sinatra/sinatra#1477) by Mike Pastore * Improve development support and documentation and source code by Anusree Prakash, Jordan Owens, @ceclinux and @krororo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added docs, testing to support erubi. I can write only Japanese and English, so I updated only them. This is related to #1487 .