Test suite errors with error_highlight #1774
Description
Running test suite against Ruby 3.1 without Bundler results in some errors:
$ ruby -e 'Dir.glob "./test/*_test.rb", &method(:require)'
cannot load such file -- asciidoctor: skipping asciidoc tests
cannot load such file -- builder: skipping builder tests
cannot load such file -- coffee-script: skipping coffee tests
cannot load such file -- creole: skipping creole tests
cannot load such file -- erubi
Did you mean? erb: skipping erubi tests
cannot load such file -- erubis: skipping erubis tests
cannot load such file -- haml: skipping haml tests
cannot load such file -- less: skipping less tests
cannot load such file -- liquid: skipping liquid tests
cannot load such file -- markaby: skipping markaby tests
cannot load such file -- pandoc-ruby: skipping markdown tests with Tilt::PandocTemplate
cannot load such file -- commonmarker: skipping markdown tests with Tilt::CommonMarkerTemplate
cannot load such file -- redcarpet: skipping markdown tests with Tilt::RedcarpetTemplate
cannot load such file -- rdiscount: skipping markdown tests with Tilt::RDiscountTemplate
cannot load such file -- kramdown: skipping markdown tests with Tilt::KramdownTemplate
cannot load such file -- maruku: skipping markdown tests with Tilt::MarukuTemplate
cannot load such file -- bluecloth: skipping markdown tests with Tilt::BlueClothTemplate
cannot load such file -- wikicloth: skipping mediawiki tests
cannot load such file -- nokogiri: skipping nokogiri tests
cannot load such file -- rabl: skipping rabl tests
cannot load such file -- radius: skipping radius tests
cannot load such file -- sass: skipping sass tests
cannot load such file -- sass: skipping scss tests
cannot load such file -- slim: skipping slim tests
cannot load such file -- stylus: skipping stylus tests
cannot load such file -- redcloth: skipping textile tests
cannot load such file -- wlang: skipping wlang tests
cannot load such file -- yajl
Did you mean? yaml: skipping yajl tests
Run options: --seed 33747
# Running:
........................................................................................................................................................................................................................................................................................................................................................F...................S...........................................................................................F....F..............................................................................................................................................................................................................................................F.................................................................................................................................................................................................................................
Finished in 2.596864s, 356.5840 runs/s, 811.3633 assertions/s.
1) Failure:
SettingsTest::TestDump_errors#test_does_not_dump_404_errors_0 [/builddir/build/BUILD/sinatra-2.2.0/usr/share/gems/gems/sinatra-2.2.0/test/settings_test.rb:387]:
Expected false to be truthy.
2) Failure:
RoutingTest#test_recalculates_body_length_correctly_for_404_response_0 [/builddir/build/BUILD/sinatra-2.2.0/usr/share/gems/gems/sinatra-2.2.0/test/routing_test.rb:174]:
--- expected
+++ actual
@@ -1 +1,3 @@
-"18"
+# encoding: US-ASCII
+# valid: true
+"64"
3) Failure:
RoutingTest#test_captures_the_exception_message_of_a_raised_NotFound_0 [/builddir/build/BUILD/sinatra-2.2.0/usr/share/gems/gems/sinatra-2.2.0/test/routing_test.rb:186]:
--- expected
+++ actual
@@ -1 +1,3 @@
-"19"
+# encoding: US-ASCII
+# valid: true
+"99"
4) Failure:
StaticTest#test_path_is_escaped_in_404_error_pages_0 [/builddir/build/BUILD/sinatra-2.2.0/usr/share/gems/gems/sinatra-2.2.0/test/static_test.rb:87]:
Unexpected response content..
--- expected
+++ actual
@@ -1 +1,4 @@
-["GET /<script>"]
+["GET /<script>
+
+ raise NotFound, "\#{request.request_method} \#{request.path_info}"
+ ^^^^^"]
926 runs, 2107 assertions, 4 failures, 0 errors, 1 skips
You have skipped tests. Run with --verbose for details.
These seems to be caused by error_highlight, because disabling it fixes the issues:
$ RUBYOPT=--disable-error_highlight ruby -e 'Dir.glob "./test/*_test.rb", &method(:require)'
cannot load such file -- asciidoctor: skipping asciidoc tests
cannot load such file -- builder: skipping builder tests
cannot load such file -- coffee-script: skipping coffee tests
cannot load such file -- creole: skipping creole tests
cannot load such file -- erubi
Did you mean? erb: skipping erubi tests
cannot load such file -- erubis: skipping erubis tests
cannot load such file -- haml: skipping haml tests
cannot load such file -- less: skipping less tests
cannot load such file -- liquid: skipping liquid tests
cannot load such file -- markaby: skipping markaby tests
cannot load such file -- pandoc-ruby: skipping markdown tests with Tilt::PandocTemplate
cannot load such file -- commonmarker: skipping markdown tests with Tilt::CommonMarkerTemplate
cannot load such file -- redcarpet: skipping markdown tests with Tilt::RedcarpetTemplate
cannot load such file -- rdiscount: skipping markdown tests with Tilt::RDiscountTemplate
cannot load such file -- kramdown: skipping markdown tests with Tilt::KramdownTemplate
cannot load such file -- maruku: skipping markdown tests with Tilt::MarukuTemplate
cannot load such file -- bluecloth: skipping markdown tests with Tilt::BlueClothTemplate
cannot load such file -- wikicloth: skipping mediawiki tests
cannot load such file -- nokogiri: skipping nokogiri tests
cannot load such file -- rabl: skipping rabl tests
cannot load such file -- radius: skipping radius tests
cannot load such file -- sass: skipping sass tests
cannot load such file -- sass: skipping scss tests
cannot load such file -- slim: skipping slim tests
cannot load such file -- stylus: skipping stylus tests
cannot load such file -- redcloth: skipping textile tests
cannot load such file -- wlang: skipping wlang tests
cannot load such file -- yajl
Did you mean? yaml: skipping yajl tests
Run options: --seed 28281
# Running:
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S................................................................................
Finished in 1.961836s, 472.0068 runs/s, 1075.5230 assertions/s.
926 runs, 2110 assertions, 0 failures, 0 errors, 1 skips
You have skipped tests. Run with --verbose for details.