smp server: improve counts management and expiration for postgres message store #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
commented
Sep 11, 2025
| total_deleted BIGINT := 0; | ||
| BEGIN | ||
| FOR rid IN | ||
| SELECT recipient_id |
Member
Author
There was a problem hiding this comment.
implicit cursor here is:
- bad for large tables
- disrupted with commits.
Instead batching is used
epoberezkin
commented
Sep 11, 2025
| del_count := delete_expired_msgs(rid, old_ts); | ||
| total_deleted := total_deleted + del_count; | ||
| EXCEPTION WHEN OTHERS THEN | ||
| ROLLBACK; |
Member
Author
There was a problem hiding this comment.
rollback is automatic here, but commit that would release lock is not, so explicit commit is still neded
spaced4ndy
reviewed
Sep 12, 2025
spaced4ndy
reviewed
Sep 12, 2025
spaced4ndy
reviewed
Sep 12, 2025
epoberezkin
force-pushed
the
ep/fix-counts
branch
from
91d9950 to
d9287d4
Compare
epoberezkin
added a commit
that referenced
this pull request
Sep 16, 2025
…sage store (#1631) * smp server: improve counts management and expiration for postgres message store * one update * fix expiration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.