docs: acknowledgements for async command responses rfc#6444
Merged
spaced4ndy merged 2 commits intomasterfrom Nov 18, 2025
Merged
docs: acknowledgements for async command responses rfc#6444spaced4ndy merged 2 commits intomasterfrom
spaced4ndy merged 2 commits intomasterfrom
Conversation
epoberezkin
reviewed
Nov 17, 2025
| TBC separate type for storing only necessary events: | ||
|
|
||
| ```haskell | ||
| data AEventDB where |
Member
There was a problem hiding this comment.
even if we want to persist some commands, no need to define type - it can be just a Bool predicate.
Contributor
Author
There was a problem hiding this comment.
this is just to consider if we want to do less encodings
epoberezkin
reviewed
Nov 17, 2025
| Save response on command before notifying chat (event received by chat via subQ). | ||
|
|
||
| ```sql | ||
| ALTER TABLE commands ADD COLUMN response BLOB; |
Member
There was a problem hiding this comment.
Suggested change
| ALTER TABLE commands ADD COLUMN response BLOB; | |
| ALTER TABLE commands ADD COLUMN event BLOB; |
Member
There was a problem hiding this comment.
and most likely we need one more field for status? or how it's tracked
Contributor
Author
There was a problem hiding this comment.
there doesn't seem much to track, once event is acknowledged command is deleted. so it's no event -> command has event saved -> command deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.