Fix file logging handler to not fail on the first write after file-creation (#1877)

tvdijen · tvdijen · commit fe26133d2d34 · 2023-10-24T15:29:56.000+02:00
diff --git a/src/SimpleSAML/Logger/FileLoggingHandler.php b/src/SimpleSAML/Logger/FileLoggingHandler.php
@@ -89,11 +89,8 @@ public function __construct(Configuration $config)
                     sprintf("Could not write to logfile: %s", $this->logFile),
                 );
             }
-        } elseif (!$this->fileSystem->touch($this->logFile)) {
-            throw new CannotWriteFileException(sprintf(
-                "The logging directory is not writable for the web server user. Could not create logfile: %s",
-                $this->logFile,
-            ));
+        } else {
+            $this->fileSystem->touch($this->logFile);
         }
 
         $timeUtils = new Utils\Time();

Original file line number	Diff line number	Diff line change
`@@ -89,11 +89,8 @@ public function __construct(Configuration $config)`
`89`	`89`	`sprintf("Could not write to logfile: %s", $this->logFile),`
`90`	`90`	`);`
`91`	`91`	`}`
`92`		`- } elseif (!$this->fileSystem->touch($this->logFile)) {`
`93`		`- throw new CannotWriteFileException(sprintf(`
`94`		`- "The logging directory is not writable for the web server user. Could not create logfile: %s",`
`95`		`- $this->logFile,`
`96`		`- ));`
	`92`	`+ } else {`
	`93`	`+ $this->fileSystem->touch($this->logFile);`
`97`	`94`	`}`
`98`	`95`
`99`	`96`	`$timeUtils = new Utils\Time();`