Default for entity nameformat when not set should be uri (#1854)

thijskh · web-flow · commit cc54022699ff · 2023-08-25T12:09:55.000+02:00
This matches both the code, and the code comments, the documentation
and the behaviour of 1.19 so it seems to be a bug due to refactoring.
diff --git a/src/SimpleSAML/Metadata/SAMLBuilder.php b/src/SimpleSAML/Metadata/SAMLBuilder.php
@@ -186,7 +186,7 @@ private function addExtensions(Configuration $metadata, RoleDescriptor $e): void
                 } else {
                     $attr[] = new Attribute(
                         name: $attributeName,
-                        nameFormat: C::NAMEFORMAT_UNSPECIFIED,
+                        nameFormat: C::NAMEFORMAT_URI,
                         attributeValue: $attrValues,
                     );
                 }

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ private function addExtensions(Configuration $metadata, RoleDescriptor $e): void`
`186`	`186`	`} else {`
`187`	`187`	`$attr[] = new Attribute(`
`188`	`188`	`name: $attributeName,`
`189`		`- nameFormat: C::NAMEFORMAT_UNSPECIFIED,`
	`189`	`+ nameFormat: C::NAMEFORMAT_URI,`
`190`	`190`	`attributeValue: $attrValues,`
`191`	`191`	`);`
`192`	`192`	`}`