Bugfix: startSLO2 may return, if the IdP has no SLO endpoint

thijskh · thijskh · commit c3fdb7f1c148 · 2023-02-15T11:01:28.000+01:00
diff --git a/modules/saml/src/Auth/Source/SP.php b/modules/saml/src/Auth/Source/SP.php
@@ -1041,7 +1041,6 @@ public function logout(array &$state): void
         Assert::oneOf($logoutType, ['saml2']);
 
         $this->startSLO2($state);
-        Assert::true(false); // Should not return
     }
 
 

Original file line number	Diff line number	Diff line change
`@@ -1041,7 +1041,6 @@ public function logout(array &$state): void`
`1041`	`1041`	`Assert::oneOf($logoutType, ['saml2']);`
`1042`	`1042`
`1043`	`1043`	`$this->startSLO2($state);`
`1044`		`- Assert::true(false); // Should not return`
`1045`	`1044`	`}`
`1046`	`1045`
`1047`	`1046`