i18n in 2.3 allow Brazilian to be selected again (#2216)

monkeyiq · tvdijen · monkeyiq · commit bc353baf750e · 2024-08-27T17:32:59.000+10:00
* i18n in 2.3 allow Brazilian to be selected again

* This is a more special case

* break the CI again but with simpler code

* Allow CI to complete with no implicit lower case on lang

* One more case of strtolower

---------

Co-authored-by: Tim van Dijen &lt;tvdijen@gmail.com&gt;
diff --git a/src/SimpleSAML/Locale/Language.php b/src/SimpleSAML/Locale/Language.php
@@ -159,7 +159,6 @@ public function getPosixLanguage(string $language): string
      */
     public function setLanguage(string $language, bool $setLanguageCookie = true): void
     {
-        $language = strtolower($language);
         if (in_array($language, $this->availableLanguages, true)) {
             $this->language = $language;
             if ($setLanguageCookie === true) {
@@ -356,7 +355,7 @@ public static function getLanguageCookie(): ?string
         $name = $config->getOptionalString('language.cookie.name', 'language');
 
         if (isset($_COOKIE[$name])) {
-            $language = strtolower($_COOKIE[$name]);
+            $language = $_COOKIE[$name];
             if (in_array($language, $availableLanguages, true)) {
                 return $language;
             }
diff --git a/tests/src/SimpleSAML/Locale/LanguageTest.php b/tests/src/SimpleSAML/Locale/LanguageTest.php
@@ -164,7 +164,7 @@ public function testSetLanguage(): void
             'language.parameter.name' => 'xyz',
             'language.parameter.setcookie' => false,
         ], '', 'simplesaml');
-        $_GET['xyz'] = 'Es'; // test also that lang code is transformed to lower caps
+        $_GET['xyz'] = 'es';
         $l = new Language($c);
         $this->assertEquals('es', $l->getLanguage());
 
