Replace exceptions with assertions

tvdijen · tvdijen · commit 5f1cf0cf4cc2 · 2023-10-25T15:47:37.000+02:00
diff --git a/modules/core/src/Auth/Process/StatisticsWithAttribute.php b/modules/core/src/Auth/Process/StatisticsWithAttribute.php
@@ -48,16 +48,15 @@ public function __construct(array &$config, $reserved)
         parent::__construct($config, $reserved);
 
         if (array_key_exists('attributename', $config)) {
-            if (!is_string($config['attributename'])) {
-                throw new Exception('Invalid attribute name given to core:StatisticsWithAttribute filter.');
-            }
+            Assert::stringNotEmpty(
+                $config['attributename'],
+                'Invalid attribute name given to core:StatisticsWithAttribute filter.',
+            );
             $this->attribute = $config['attributename'];
         }
 
         if (array_key_exists('type', $config)) {
-            if (!is_string($config['type'])) {
-                throw new Exception('Invalid typeTag given to core:StatisticsWithAttribute filter.');
-            }
+            Assert::stringNotEmpty($config['type'], 'Invalid typeTag given to core:StatisticsWithAttribute filter.');
             $this->typeTag = $config['type'];
         }
 
