Fix: properly check for existing headers

tvdijen · tvdijen · commit 3d4fa4a25800 · 2023-09-04T09:11:16.000+02:00
diff --git a/public/admin/index.php b/public/admin/index.php
@@ -14,7 +14,7 @@
 $response = $httpUtils->redirectTrustedURL($redirect);
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }
diff --git a/public/index.php b/public/index.php
@@ -14,7 +14,7 @@
 $response = $httpUtils->redirectTrustedURL($redirect);
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }
diff --git a/public/module.php b/public/module.php
@@ -17,7 +17,7 @@
 $response = Module::process();
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }
diff --git a/public/saml2/idp/ArtifactResolutionService.php b/public/saml2/idp/ArtifactResolutionService.php
@@ -23,7 +23,7 @@
 $response = $controller->ArtifactResolutionService($request);
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }
diff --git a/public/saml2/idp/SSOService.php b/public/saml2/idp/SSOService.php
@@ -23,7 +23,7 @@
 $response = $controller->singleSignOnService($request)->send();
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }
diff --git a/public/saml2/idp/SingleLogoutService.php b/public/saml2/idp/SingleLogoutService.php
@@ -23,7 +23,7 @@
 $response = $controller->singleLogout($request)->send();
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }
diff --git a/public/saml2/idp/initSLO.php b/public/saml2/idp/initSLO.php
@@ -23,7 +23,7 @@
 $response = $controller->initSingleLogout($request);
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }
diff --git a/public/saml2/idp/metadata.php b/public/saml2/idp/metadata.php
@@ -23,7 +23,7 @@
 $response = $controller->metadata($request);
 foreach ($headers as $header => $value) {
     // Some pages may have specific requirements that we must follow. Don't touch them.
-    if (!$response->has($header)) {
+    if (!$response->headers->has($header)) {
         $response->headers->set($header, $value);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`$response = $httpUtils->redirectTrustedURL($redirect);`
`15`	`15`	`foreach ($headers as $header => $value) {`
`16`	`16`	`// Some pages may have specific requirements that we must follow. Don't touch them.`
`17`		`- if (!$response->has($header)) {`
	`17`	`+ if (!$response->headers->has($header)) {`
`18`	`18`	`$response->headers->set($header, $value);`
`19`	`19`	`}`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`$response = Module::process();`
`18`	`18`	`foreach ($headers as $header => $value) {`
`19`	`19`	`// Some pages may have specific requirements that we must follow. Don't touch them.`
`20`		`- if (!$response->has($header)) {`
	`20`	`+ if (!$response->headers->has($header)) {`
`21`	`21`	`$response->headers->set($header, $value);`
`22`	`22`	`}`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`$response = $controller->ArtifactResolutionService($request);`
`24`	`24`	`foreach ($headers as $header => $value) {`
`25`	`25`	`// Some pages may have specific requirements that we must follow. Don't touch them.`
`26`		`- if (!$response->has($header)) {`
	`26`	`+ if (!$response->headers->has($header)) {`
`27`	`27`	`$response->headers->set($header, $value);`
`28`	`28`	`}`
`29`	`29`	`}`