Skip to content

Fix for PHP 7.1#458

Merged
mblaney merged 1 commit intosimplepie:masterfrom
remicollet:patch-1
Jul 28, 2016
Merged

Fix for PHP 7.1#458
mblaney merged 1 commit intosimplepie:masterfrom
remicollet:patch-1

Conversation

@remicollet
Copy link
Copy Markdown
Contributor

@remicollet remicollet commented Jul 7, 2016

Without:

There were 60 errors:

1) OldTest::testOld with data set #60 (SimplePie_Date_Test_RFC3339_2 Object (...))
A non-numeric value encountered

/dev/shm/BUILDROOT/php-simplepie-1.4.2-1.fc23.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Parse/Date.php:693
/dev/shm/BUILDROOT/php-simplepie-1.4.2-1.fc23.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Parse/Date.php:602
/dev/shm/BUILDROOT/php-simplepie-1.4.2-1.fc23.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Misc.php:1763
/dev/shm/BUILD/simplepie-9b775e88ba1128fa14c69ff94ab954d86067de2a/tests/oldtests/functions.php:124
/dev/shm/BUILD/simplepie-9b775e88ba1128fa14c69ff94ab954d86067de2a/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-9b775e88ba1128fa14c69ff94ab954d86067de2a/tests/oldtests.php:82

With, same result than PHP 7.0 (Failure on IRITest.php)

@mblaney mblaney merged commit 82ecc9b into simplepie:master Jul 28, 2016
@mblaney
Copy link
Copy Markdown
Member

mblaney commented Jul 28, 2016

thanks @remicollet

This was referenced Mar 26, 2017
Closed
Merged
@david-robinson-practiceweb david-robinson-practiceweb mentioned this pull request May 22, 2018
Closed
@davidohlin davidohlin mentioned this pull request Jul 2, 2018
Open
5 tasks
@uglyeoin uglyeoin mentioned this pull request Jun 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remicollet @mblaney