Error message when XML or PCRE extensions missing

Alkarex · Alkarex · commit d0d1f9fe2b2e · 2016-08-28T17:06:52.000+02:00
The XML extension is not loaded by default on PHP7. Relevant to have the reason of failure in the error message instead of returning an empty error message. FreshRSS/FreshRSS#1230 FreshRSS/FreshRSS#1227 (comment)
diff --git a/library/SimplePie.php b/library/SimplePie.php
@@ -1294,6 +1294,7 @@ public function init()
 		// Check absolute bare minimum requirements.
 		if (!extension_loaded('xml') || !extension_loaded('pcre'))
 		{
+			$this->error = 'XML or PCRE extensions not loaded!';
 			return false;
 		}
 		// Then check the xml extension is sane (i.e., libxml 2.7.x issue on PHP < 5.2.9 and libxml 2.7.0 to 2.7.2 on any version) if we don't have xmlreader.

Original file line number	Diff line number	Diff line change
`@@ -1294,6 +1294,7 @@ public function init()`
`1294`	`1294`	`// Check absolute bare minimum requirements.`
`1295`	`1295`	`if (!extension_loaded('xml') \|\| !extension_loaded('pcre'))`
`1296`	`1296`	`{`
	`1297`	`+ $this->error = 'XML or PCRE extensions not loaded!';`
`1297`	`1298`	`return false;`
`1298`	`1299`	`}`
`1299`	`1300`	`// Then check the xml extension is sane (i.e., libxml 2.7.x issue on PHP < 5.2.9 and libxml 2.7.0 to 2.7.2 on any version) if we don't have xmlreader.`