Conversation
|
We should merge the other PR first as this one also includes those changes from the calibrated sensor. If the HybridStepper moves to main library, then I guess it’s better to remove it completely here. |
|
Hmm even after merging the other PR this one still shows all the same changes… whereas I think we want only the last commit from this PR, actually. If it’s ok I’ll just make a new commit where I remove the old HybridStepper - I’ll leave the folder and point to the new functionality in its ReadMe |
|
Yeah sure, go for it, I'm in for removing it. |
|
Ok I've rebased it and it is ok now. So yeah, if you want you can also just remove it and discard this PR. |
|
I merged it. |
2 participants
Provided that we move the HybridStepperClass to main this class in the drivers can either be removed or renamed. Here I've renamed it to HybridStepperMotorOld - it is not 100% the same as the one in the PR simplefoc/Arduino-FOC#457.
As it does not implement the current sensing and still has the issue with the space vector calculation explained here: https://community.simplefoc.com/t/driving-two-phase-bilpolar-steppers-with-three-phase-bldc-driver-hybrid-stepper-motor/5043