Merged
Conversation
this is to use the enable pin on the DRV8316, which is actually a driver_off pin, and therefore active-low for enabled state
this enables two things: 1. you can still see the sensors change and update in SimpleFOCStudio even if you disable the motor. This is useful to determine sensor accuracy etc. 2. you previously ran the risk of losing track of full rotations if the motor was (e.g. manually) moved while disabled. With this change we always track the sensor values and keep track of all rotations.
Member
|
Awesome, great work! 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 changes:
added an enable_active_high field to BLDCDriver6PWM. The DRV8316 has an "drvoff" pin - e.g. an enable pin that is active-low. This simple change enables configuring the enable/disable function to support active-low.
SAMD21/SAMD51 PWM code updates. SAME51 support (trivially, code is same as for SAMD51).
moved the location of the sensor calls in move() and loopFOC() to before the enable checks. This means SimpleFOCStudio keeps displaying the values, and also disabled motors don't lose track of full rotations.