Conversation
Member
|
Richard that is perfect! I have a question before I merge it. Are you sure that I suppose we can create different types of handlers for different communications. |
Member
Author
|
Awesome! I will do some tests on the merged code and report back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the SAMD21 support updated against the dev branch. I tested it on an Nano 33 IoT, and could not see any difference to the version that I'd branched from master.
I had to make one change to the new Commander class: it was using "HardwareSerial", but SAMD21 "standard serial" is via the USB port, and uses "USBSerial". So I changed Commander to user "Stream", which is the common subclass of both of these. The code itself was not using any methods that aren't in Stream anyway.
This looks better now, and could be merged without conflicts.
The only changes to existing code are the mentioned Commander class changes, and adding the SAMD21 define in generic_mcu.cpp.