g431-esc: use internal ADC channels, also fix some typos#487
Merged
runger1101001 merged 5 commits intosimplefoc:devfrom Nov 2, 2025
Merged
g431-esc: use internal ADC channels, also fix some typos#487runger1101001 merged 5 commits intosimplefoc:devfrom
runger1101001 merged 5 commits intosimplefoc:devfrom
Conversation
Member
|
Ok so let’s merge it? What’s the status of your testing it? I’m hesitant because I don’t have a test setup for it myself. |
Member
|
Ok all checks have passed. Let’s merge this :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the opamps amplify, then the signal goes outside to the pin, where it is taken back into the microcontroller to be converted.
The argument for this was that it allows filtering, but since the pin goes in and out, that would rely entirely on the output impedance of the opamp to do filtering, and in the case of this board, only one pin is actually broken out as a test pad.
This changes that and makes the board use the internal opamp to ADC channels. It is also now possible to use -1 to -3 to access the opamp readings, since in other boards, these may not have any pins assigned.
This change can be turned off by a define.