Add current and voltage feed forward terms to motor classes#454
Merged
runger1101001 merged 1 commit intosimplefoc:devfrom Jul 28, 2025
Merged
Add current and voltage feed forward terms to motor classes#454runger1101001 merged 1 commit intosimplefoc:devfrom
runger1101001 merged 1 commit intosimplefoc:devfrom
Conversation
Member
|
Hey @Copper280z thanks so much. This looks great, and I will merge it right after doing the 2.3.5 release. Its an important change, and we'll also have to update the docs accordingly, so I don't want to rush it for this release if that's ok? |
Contributor
Author
|
That’s totally fine by me, I’d rather have more testing time than less before it’s released. |
Member
|
We've released v2.3.5 so I have merged this now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds feed forward terms for the voltage and current controllers. This allows including inputs using system parameters and knowledge not available to the PID controllers to improve performance.
Some examples of use cases might be using the moving inertia with an S-curve motion profile to calculate the torque (current) required to follow the profile. Without feed forward, following error depends solely on the PID controller, with feed forward the PID controller is only responsible for compensating unmodeled disturbances. Another example would be using a motor to resist a known load, like gravity, or a spring, while in angle or velocity control mode. This currently would depend on the PID controller to compensate for the load, but because the load is well known it can be calculated directly. The response of the system to predicable changes in this load no longer depends on the PID controller bandwidth.
This change still needs testing, but I wanted to get it out there while I had a chance. :)