fix some bugs in B-G431-ESC1 example#343
Closed
zhangyq-227 wants to merge 1 commit intosimplefoc:devfrom
Closed
Conversation
Member
|
Thank you very much for reporting this! Your English is just fine, I understand you perfectly. |
Member
|
I've changed this PR from main to dev branch, we only accept changes to the dev branch. However, there are also some compilation problems with this PR - I think it doesn't like the lib_archive=false in the build_opts file. Normally this option should be put in your platformio.ini file... Also your changes to the example file include changing the sensor type, using current sensing, etc... so I think we should restrict the changes just to the bug itself, if possible. I think if it is ok with you and to save you further work I will manually introduce just the change with the missing loopFOC() in a separate commit. |
Member
|
Done, in this PR: #349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I find some bugs in B-G432B-ESC1 example when I test.
All changes are verified on my real hardware.
I‘m sorry, My English is not very good. I look forward to your reply.
Wish you a happy life.