renesas: disable capture interrupt before open()#322
Merged
runger1101001 merged 1 commit intosimplefoc:devfrom Sep 27, 2023
Merged
renesas: disable capture interrupt before open()#322runger1101001 merged 1 commit intosimplefoc:devfrom
runger1101001 merged 1 commit intosimplefoc:devfrom
Conversation
Member
|
Thank you so much for this! It makes complete sense. What I don't understand is why only the WiFi was affected, an not the Minima. I will merge to our dev branch and test it. |
Member
|
Thanks @facchinm ❤️ this has indeed fixed the problem. |
Member
|
arduino/ArduinoCore-renesas#139 could be closed but I am still blocked from commenting on it / closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes arduino/ArduinoCore-renesas#139
Renesas fsp structures must be properly initialized entirely since
memsetting all to 0 makes some values "valid" (in this case, the capture irq was firing as 0 instead than the agt interrupt, leading to a null pointer crash)