SVPWM with midpoint clamp#309
Merged
runger1101001 merged 5 commits intosimplefoc:devfrom Sep 23, 2023
Merged
Conversation
This was referenced Sep 14, 2023
Open
Member
|
I'm on-board with this. The question is whether we want to put it in this release (2.3.1) which is very close to happening, or merge it to the dev branch afterwards, for the 2.4.0 release? |
Collaborator
Author
|
I wouldn't want to mess up with the 2.3.1 release if there is not enough feedback about my change. |
Member
|
Just waiting for the Arduino library manager to pick up the new release, make sure everything is ok, and then I will merge this to the dev branch... |
Collaborator
Author
|
Take your time. Thanks for the new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @runger1101001 and @askuric,
Hope this is the right way to contribute.
This is what I proposed here.
Before the change:
RAM: [= ] 9.2% (used 4536 bytes from 49152 bytes)
Flash: [=== ] 27.1% (used 71076 bytes from 262144 bytes)
loopfoc takes up to 220us with SVPWM
After the change:
RAM: [= ] 9.2% (used 4536 bytes from 49152 bytes)
Flash: [=== ] 26.6% (used 69676 bytes from 262144 bytes)
loopfoc takes up to 156us with SVPWM
loopfoc takes up to 152us with SinePWM
I only saw a very small difference in magnitude between the old and new SVPWM without center modulation.
With center modulation it's exactly the same.
I decide to just add SVPWM to the SinePWM code and not duplicate all the code.