Typo in pin assignment configuration for 4PWM#182
Merged
runger1101001 merged 8 commits intosimplefoc:devfrom May 23, 2022
Merged
Typo in pin assignment configuration for 4PWM#182runger1101001 merged 8 commits intosimplefoc:devfrom
runger1101001 merged 8 commits intosimplefoc:devfrom
Conversation
Create CODE_OF_CONDUCT.md
|
I confirm on my side, using Arduino nano, this bug fix worked fine |
Member
|
I will merge this. It includes some things that were committed against the master branch only, but these should probably be merged to dev anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made this small correction in multiple files. Once I did my project seem to work better. I still need some hardware. Without knowing the inner workings of the project. It does look like a simple typo that got copied over multiple files.