Skip to content

Conversation

@DeNeutoy
Copy link
Contributor

Addresses #246 - this is a bit of a kludge because it doesn't actually validate the FTS string, just makes sure that it will not crash when executed, but I figured that building a query parser is a bit out of the scope of sqlite-utils and if you actually want to use the query language, you probably need to parse that yourself.

@simonw
Copy link
Owner

simonw commented Aug 18, 2021

This was also requested in #296.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #247 (af989af) into main (1fe73c8) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   96.28%   96.24%   -0.04%     
==========================================
  Files           5        5              
  Lines        2179     2186       +7     
==========================================
+ Hits         2098     2104       +6     
- Misses         81       82       +1     
Impacted Files Coverage Δ
sqlite_utils/db.py 97.84% <85.71%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe73c8...af989af. Read the comment docs.

@simonw simonw merged commit 53fec0d into simonw:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants