Skip to content

insert_all(..., alter=True) should work for new columns introduced after the first 100 records #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2020

Conversation

simonwiles
Copy link
Contributor

Closes #139.

@simonw
Copy link
Owner

simonw commented Aug 28, 2020

Thanks very much!

@simonw
Copy link
Owner

simonw commented Aug 28, 2020

Looks like it failed the "black" formatting test - possibly because there's a new release if black out. I'm going to merge despite that failure.

@simonw
Copy link
Owner

simonw commented Aug 28, 2020

Yeah I think that failure is actually because there's a brand new release of Black out and it subtly changes some of the formatting rules. I'll merge this and then run Black against the entire codebase.

@simonw simonw merged commit 947bb76 into simonw:main Aug 28, 2020
simonw added a commit that referenced this pull request Aug 28, 2020
simonw added a commit that referenced this pull request Aug 28, 2020
@simonwiles simonwiles deleted the always-check-columns branch August 30, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insert_all(..., alter=True) should work for new columns introduced after the first 100 records
2 participants