Skip to content

Turn --flatten into a documented utility function #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonw opened this issue Oct 18, 2022 · 4 comments
Closed

Turn --flatten into a documented utility function #500

simonw opened this issue Oct 18, 2022 · 4 comments
Labels
enhancement New feature or request python-library

Comments

@simonw
Copy link
Owner

simonw commented Oct 18, 2022

The --flatten implementation isn't currently available to Python code - people have to roll their own implementation. Feedback from a conversation at DjangoCon.
@simonw simonw added enhancement New feature or request python-library labels Oct 18, 2022
@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022

Here's how it works:

sqlite-utils/sqlite_utils/cli.py

Lines 1847 to 1848 in d792dad

if flatten:
rows = (dict(_flatten(row)) for row in rows)

sqlite-utils/sqlite_utils/cli.py

Lines 1082 to 1088 in d792dad

def _flatten(d):
for key, value in d.items():
if isinstance(value, dict):
for key2, value2 in _flatten(value):
yield key + "_" + key2, value2
else:
yield key, value

@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022

It should go in sqlite_utils.utils - documented here: https://sqlite-utils.datasette.io/en/stable/reference.html#sqlite-utils-utils

@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022 •
edited
Loading

I think the public interface is a flatten(row) function that does dict(_flatten(row)).

@simonw simonw closed this as completed in 34e75ed Oct 18, 2022
@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022

Documentation: https://sqlite-utils.datasette.io/en/latest/reference.html#sqlite-utils-utils-flatten

simonw referenced this issue Oct 18, 2022
@simonw
Run cog -r against latest tabulate, refs #501
eb67fc6
@simonw simonw mentioned this issue Oct 25, 2022
Closed
simonw added a commit that referenced this issue Oct 25, 2022
@simonw
Release 3.30
0d45ee1 
Refs #480, #483, #485, #495, #500, #502, #504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request python-library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw