Conversation
Owner
Author
|
I removed this bit of a test: # Now update a column that's part of the compound primary key
time.sleep(0.1)
if pks == ["id", "name"]:
db[table_name].update((2, "Pancakes"), {"name": "Pancakes the corgi"})
# This should have renamed the row in the chronicle table as well
renamed_row = db[chronicle_table].get((2, "Pancakes the corgi"))
assert renamed_row["updated_ms"] > version
else:
# Update single primary key
db[table_name].update(2, {"id": 4})
# This should have renamed the row in the chronicle table as well
renamed_row = db[chronicle_table].get(4)
assert renamed_row["updated_ms"] > version |
Owner
Author
|
This code here: sqlite-chronicle/sqlite_chronicle.py Lines 229 to 246 in 5c28eee Assumes that sqlite-chronicle/sqlite_chronicle.py Lines 121 to 129 in 5c28eee |
Owner
Author
|
I switched to a window function to assign those incrementing version numbers as part of that initial insert. https://chatgpt.com/share/681e5184-0448-8006-bd11-67be8379161e |
simonw
added a commit
that referenced
this pull request
May 9, 2025
simonw
added a commit
that referenced
this pull request
May 9, 2025
Closed
simonw
added a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
TODO:
updates_since()working correctly