String methods use microjs.regex #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Python's `re` module with the internal microjs.regex engine for all String methods that use regex patterns. This ensures: - ReDoS protection via step limits and timeout polling - Consistent behavior with the rest of the regex implementation - Proper sandboxing when executing untrusted code Implementation details: - All four methods now use `JSRegExp._internal` (microjs.regex.RegExp) - Creates fresh regex VM for each search to avoid lastIndex issues - Catches RegexTimeoutError and converts to TimeLimitError - Handles capture groups correctly (capture_count includes group 0) Added comprehensive tests including: - Edge cases (case-insensitive, multiline, zero-width matches) - Time limit/ReDoS protection tests with parametrized methods - Robust tests for various scenarios (global vs non-global, groups, etc.) Closes #15
simonw
commented
Dec 27, 2025
Comment on lines
+1866
to
+1867
| # Create fresh regex VM for each search to avoid lastIndex issues | ||
| vm_regex = regex_internal._create_vm() |
Owner
Author
There was a problem hiding this comment.
Sounds inefficient, I wonder what the performance hit here is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Python's
remodule with the internal microjs.regex engine for all String methods that use regex patterns. This ensures:Implementation details:
JSRegExp._internal(microjs.regex.RegExp)Added comprehensive tests including:
Closes #15
https://gistpreview.github.io/?e0b4931c8962017eee467e6e9cd1d49d/index.html