Skip to content

JSRegExp(pattern, flags, poll_callback=check_timeout) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonw merged 2 commits into from
Dec 27, 2025
Merged

JSRegExp(pattern, flags, poll_callback=check_timeout) #14

simonw merged 2 commits into from
Dec 27, 2025

Conversation

@simonw
Copy link
Owner

@simonw simonw commented Dec 27, 2025 •
edited
Loading

Fixes #13 - Regex operations now respect the Context's time_limit.

Changes:

  • Pass poll_callback to JSRegExp in BUILD_REGEX opcode
  • Pass poll_callback to JSRegExp in RegExp constructor
  • Convert RegexTimeoutError to TimeLimitError in regex methods
  • Use time.monotonic() instead of time.time() for reliable timeout checks
  • Add parameterized tests for regex literal and constructor timeout
  • Add docs/regex.md with Python API documentation for direct regex usage

https://gistpreview.github.io/?6f81b908faf7ca6e5e0fd901cf49599d/index.html

claude and others added 2 commits December 27, 2025 16:22
@claude
Connect poll_callback to main VM's time_limit in regex engine
088fc2f 
Fixes #13 - Regex operations now respect the Context's time_limit.

Changes:
- Pass poll_callback to JSRegExp in BUILD_REGEX opcode
- Pass poll_callback to JSRegExp in RegExp constructor
- Convert RegexTimeoutError to TimeLimitError in regex methods
- Use time.monotonic() instead of time.time() for reliable timeout checks
- Add parameterized tests for regex literal and constructor timeout
- Add docs/regex.md with Python API documentation for direct regex usage
@simonw
Not safe note
d33c11b
@simonw
Copy link
Owner Author

simonw commented Dec 27, 2025

Here's the new test:

micro-javascript/tests/test_jscontext_regexp.py

Lines 180 to 205 in d33c11b

@pytest.mark.parametrize(
"regex_code",
[
# Regex literal
"var re = /(a+)+b/;",
# RegExp constructor
'var re = new RegExp("(a+)+b");',
],
ids=["literal", "constructor"],
)
def test_regex_respects_time_limit(self, regex_code):
"""Test that regex operations respect Context time_limit.
This uses a pattern known to cause catastrophic backtracking:
(a+)+b matching against 'aaa...c' causes exponential backtracking.
"""
from microjs import TimeLimitError
ctx = Context(time_limit=0.1)
with pytest.raises(TimeLimitError):
ctx.eval(
f"""
{regex_code}
re.test("aaaaaaaaaaaaaaaaaaaaaaaaaaac");
"""
)

@simonw simonw merged commit b320fb4 into main Dec 27, 2025
10 checks passed
@simonw simonw deleted the claude/add-arrow-functions-gNwf8 branch December 27, 2025 16:29
@simonw simonw added the sandbox Sandboxing to safely run untrusted code label Dec 27, 2025
simonw added a commit that referenced this pull request Dec 27, 2025
@simonw
Release 0.1a3
6883f90 
Refs #9, #10, #14, #16, #17, #18, #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

sandbox Sandboxing to safely run untrusted code

Projects

None yet

Milestone

No milestone

3 participants

@simonw @claude