Skip to content

Run tests in GitHub Actions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonw merged 22 commits into from
Jun 11, 2021
Merged

Run tests in GitHub Actions #33

simonw merged 22 commits into from
Jun 11, 2021

Conversation

@simonw
Copy link
Owner

@simonw simonw commented Jun 11, 2021

Refs #32

@simonw
Copy link
Owner Author

simonw commented Jun 11, 2021 

AssertionError: assert
  ('1/2: categories\n'\n '2/2: products\n'\n '\n'\n 'Adding 1 foreign key\n'\n '  products.cat_id => categories.id\n') == 
  ('1/2: categories\n'\n '\n'\n '2/2: products\n'\n '\n'\n '\n'\n 'Adding 1 foreign key\n'\n '  products.cat_id => categories.id\n')

There's some extra whitespace in there for some reason.

@simonw
Copy link
Owner Author

simonw commented Jun 11, 2021

It's because of a click upgrade!

pip freeze | grep click
click==7.1.2

Those tests pass. If I upgrade to Click 8 they fail.

@simonw
Copy link
Owner Author

simonw commented Jun 11, 2021

That test failure is in here:

db-to-sqlite/db_to_sqlite/cli.py

Lines 126 to 137 in 6570467

if progress:
click.echo(
"\nAdding {} foreign key{}\n{}".format(
len(foreign_keys_to_add_final),
"s" if len(foreign_keys_to_add_final) != 1 else "",
"\n".join(
" {}.{} => {}.{}".format(*fk)
for fk in foreign_keys_to_add_final
),
),
err=True,
)

@simonw simonw merged commit f2aecb8 into main Jun 11, 2021
@simonw simonw deleted the github-actions branch June 11, 2021 21:56
simonw added a commit that referenced this pull request Jun 11, 2021
@simonw
Release 1.4
91fa52b 
Refs #19, #25, #28, #29, #31, #33, #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonw