Fix errors occurred with Intervention Image 3.3.1#27
Merged
simonhamp merged 5 commits intosimonhamp:mainfrom Jan 26, 2024
olivervogel:main
Merged
Fix errors occurred with Intervention Image 3.3.1#27simonhamp merged 5 commits intosimonhamp:mainfrom olivervogel:main
simonhamp merged 5 commits intosimonhamp:mainfrom
olivervogel:main
Conversation
In the course of the Intervention Image update, there was a change which means that it is no longer possible to instantiate so-called "driver-specific" modifiers yourself. In this package, this initialization is always done by a generic class via the respective driver class. This fix sets the initialization to the static helper method used by the driver of the dependency itself.
Owner
|
Thanks for preparing this PR @olivervogel ! Greatly appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the course of the update of the Intervention Image, there was a change which means that it is no longer possible to instantiate so-called "driver-specific" modifiers yourself. After the update the initialization is always done by a generic class via the respective driver class. This fix sets the initialization of the "driver specific class" to the static helper method used by the driver of the dependency itself.
See Intervention/image#1281