Merged
Conversation
The positioning was based on the defined size of the box rather than the actual dimensions of the image This resolves that by 'pre-rendering' the image and getting its final dimensions before positioning the box
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
NaturalandCover:Naturalkeeps the ratio of the image and simply scales it down to the size defined in the layout - the final box size will depend on the dimensions of the original image. The lower of thePictureBox's width and height is used as the width of the imageCoverforces the image into thePictureBox's dimensions, scaling the image as necessary to make sure that it covers the space. This always occurs from the center of the imageChanged
Picture) - this keeps all of their config (path, opacity, placement) together and allows for a cleaner, more consistent API