Conversation
Shatur
force-pushed
the
bevy-0.17
branch
6 times, most recently
from
5f5dbcb to
cb1f9ea
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
==========================================
- Coverage 78.36% 78.30% -0.06%
==========================================
Files 57 56 -1
Lines 3235 3240 +5
==========================================
+ Hits 2535 2537 +2
- Misses 700 703 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For details see bevyengine/bevy#19121 bevyengine/bevy#18704 The niche is now in the index, which makes the compression logic even simpler.
- State now initialized separately. - Updating archetype access no longer needed. - `new_archetype` no longer exists and archetype cache needs to be updated in `get_param`. - `ReplicationRules` resource no longer need to be cloned. For details see bevyengine/bevy#16885 bevyengine/bevy#19143
- Messages and events work, but `trigger_targets` does nothing. - Updated naming across the project, except in the `event` modules. Remote events and messages require re-architecture. We no longer need to buffer events or use custom methods to trigger them. That's why the naming in `event` remains unchanged, with several TODOs left in place.
We no longer need custom sed/de to additionally serialize targets. This allows us to express things a bit nicer using conversion traits.
No other type or variable name changes.
No type or variable name changes.
Fits better.
UkoeHB
requested changes
Oct 3, 2025
Collaborator
UkoeHB
left a comment
UkoeHB
left a comment
There was a problem hiding this comment.
Minor nits, can merge once fixed
Co-authored-by: UkoeHB <[email protected]>
UkoeHB
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put each logical change into a separate commit. I'd recommend to review them separately.
Some of them are just incremental module renames to make it easier to review "event" -> "message" and "trigger" -> "event" types of rename.