Skip to content

Use FromReflect when replicating components into dynamic scenes#381

Merged
Shatur merged 2 commits intomasterfrom
from-reflect-clone
Jan 5, 2025
Merged

Use FromReflect when replicating components into dynamic scenes#381
Shatur merged 2 commits intomasterfrom
from-reflect-clone

Conversation

@Shatur
Copy link
Copy Markdown
Contributor

@Shatur Shatur commented Jan 5, 2025

For details see bevyengine/bevy#15174

@Shatur Shatur enabled auto-merge (squash) January 5, 2025 16:14
@Shatur Shatur requested a review from UkoeHB January 5, 2025 16:14
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (9826d5d) to head (14ee015).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/scene.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   90.22%   90.20%   -0.03%     
==========================================
  Files          46       46              
  Lines        2569     2573       +4     
==========================================
+ Hits         2318     2321       +3     
- Misses        251      252       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur merged commit 501a5c6 into master Jan 5, 2025
@Shatur Shatur deleted the from-reflect-clone branch January 5, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants