Skip to content

fix some ppc64 problems#952

Merged
pauldreik merged 8 commits intomasterfrom
ppc_amalgamation_tests
Mar 30, 2026
Merged

fix some ppc64 problems#952
pauldreik merged 8 commits intomasterfrom
ppc_amalgamation_tests

Conversation

@pauldreik
Copy link
Copy Markdown
Collaborator

@pauldreik pauldreik commented Mar 28, 2026

There were some feature macros that were incorrect.
Also, fixed some warnings about missing override.

I was able to find problems with:

sudo apt install g++-14-powerpc64-linux-gnu
scripts/amalgamation_tests.py  --compiler /usr/bin/powerpc64-linux-gnu-g++-14 --test-random 0 --warnings

This should fix https://gitlab.gnome.org/GNOME/vte/-/issues/2926

@pauldreik pauldreik force-pushed the ppc_amalgamation_tests branch from 1918a1c to 8192dc9 Compare March 28, 2026 19:49
@pauldreik pauldreik changed the title ci: extend ppc64 test with amalgamation fix some ppc64 problems Mar 28, 2026
@pauldreik pauldreik force-pushed the ppc_amalgamation_tests branch from 8192dc9 to 0015f5e Compare March 29, 2026 07:30
@pauldreik pauldreik marked this pull request as ready for review March 29, 2026 12:07
@pauldreik pauldreik requested a review from lemire March 29, 2026 12:07
@lemire
Copy link
Copy Markdown
Member

lemire commented Mar 30, 2026

See #953

working with fixing selective amalgamation
it now passes
./amalgamation_tests.py  --compiler /usr/bin/powerpc64le-linux-gnu-g++-14 --test-singles --warnings --standard 23
ran with this:
./amalgamation_tests.py  --compiler /usr/bin/powerpc64le-linux-gnu-g++-14 --test-random 0 --warnings --standard 23
@pauldreik pauldreik force-pushed the ppc_amalgamation_tests branch from fd6806a to 7538785 Compare March 30, 2026 04:49
@pauldreik pauldreik merged commit 3b1495a into master Mar 30, 2026
104 checks passed
@pauldreik pauldreik deleted the ppc_amalgamation_tests branch March 30, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants