inlining get_default_implementation and get_single_implementation#932
Merged
inlining get_default_implementation and get_single_implementation#932
Conversation
added 2 commits
February 5, 2026 18:39
inlined, for best performance.
pauldreik
approved these changes
Feb 6, 2026
Collaborator
pauldreik
left a comment
pauldreik
left a comment
There was a problem hiding this comment.
nice catch!
did you measure any performance difference?
Member
Author
Yes, maybe 5% of 10% difference on very short calls in some instances. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The the get_default_implementation and get_single_implementation functions should be inlined, for best performance. (They appear in the profiling data.)