This adds 'override' annotations for RVV, lasx and lsx.#931
Merged
Conversation
pauldreik
force-pushed
the
add_override
branch
from
cdaeab1 to
9192b89
Compare
Collaborator
|
looks good! pushed a commit with the formatting applied. |
Collaborator
|
on gitlab, there is a button "merge when CI is green". that button would be great on github too. |
pauldreik
approved these changes
Feb 5, 2026
Member
Author
|
I'll merge eagerly. I don't expect that you broke the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The override annotation is not super useful in my experience, but it does add a bit of clarity to the code.