Fix typos#888
Conversation
| } | ||
| #endif | ||
| #define SIMDUTF_GET_CURRENT_IMPLEMENTION | ||
| #define SIMDUTF_GET_CURRENT_IMPLEMENTATION |
There was a problem hiding this comment.
Not being used anywhere?
$ rg SIMDUTF_GET_CURRENT_IMPLEMENTION
src/implementation.cpp
1425:#define SIMDUTF_GET_CURRENT_IMPLEMENTION
There was a problem hiding this comment.
seems like it can be removed entirely!
|
thanks! |
|
@kianmeng Any chance you might omit If it is inconvenient, we may still merge this PR... |
|
@lemire @pauldreik |
|
looks good! |
|
@pauldreik Although we can merge and then lint. It is not a very challenging problem. :-) |
|
@pauldreik Clang patch applied, ddd1a28 |
|
Thanks @kianmeng ! |
|
🥳 🥳 🥳 🥳 🥳 |
Short title (summary): Fix typos
Description
Found via
codespell -S ./build,./benchmarks/competition -L vie,persan,fo,ans,larg,indx,shft,carryinandtypos --hidden --format briefType of change
How to verify / test
Please read before contributing:
If you can, we recommend running our tests with the sanitizers turned on.
For non-Visual Studio users, it is as easy as doing:
Our CI checks, among other things, for trailing whitespace.
Checklist before submitting
Final notes
Thanks for the contribution!