Skip to content

interop with std::text_encoding#881

Merged
pauldreik merged 1 commit intosimdutf:masterfrom
shikharish:std_text_encoding
Dec 30, 2025
Merged

interop with std::text_encoding#881
pauldreik merged 1 commit intosimdutf:masterfrom
shikharish:std_text_encoding

Conversation

@shikharish
Copy link
Copy Markdown
Contributor

Related to #845

@shikharish
Copy link
Copy Markdown
Contributor Author

Tested on g++-15 on MacOS(M1). I believe std::text_encoding is only available in libstdc++ for now. clang-21 doesn't seem to support it.

@shikharish
Copy link
Copy Markdown
Contributor Author

@lemire Request for review.

Comment thread include/simdutf/encoding_types.h
Copy link
Copy Markdown
Collaborator

@pauldreik pauldreik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Comment thread include/simdutf/encoding_types.h
Comment thread include/simdutf/encoding_types.h Outdated
Comment thread src/encoding_types.cpp Outdated
Comment thread tests/text_encoding_tests.cpp
Comment thread tests/CMakeLists.txt Outdated
@pauldreik
Copy link
Copy Markdown
Collaborator

I added a PR with a C++26 build: #883

@lemire
Copy link
Copy Markdown
Member

lemire commented Dec 29, 2025

No need to worry about the clang format error/warning.

@shikharish
Copy link
Copy Markdown
Contributor Author

Made the requested changes.

Copy link
Copy Markdown
Collaborator

@pauldreik pauldreik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there!

Comment thread tests/CMakeLists.txt Outdated
Comment thread src/encoding_types.cpp Outdated
Comment thread tests/text_encoding_tests.cpp Outdated
Comment thread tests/text_encoding_tests.cpp Outdated
@pauldreik
Copy link
Copy Markdown
Collaborator

let's merge this when the CI is green

@pauldreik pauldreik merged commit ead4d9c into simdutf:master Dec 30, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants