Treat C++20 char8_t as byte-like#877
Merged
pauldreik merged 2 commits intosimdutf:masterfrom Dec 16, 2025
leezaj:support-char8_t
Merged
Treat C++20 char8_t as byte-like#877pauldreik merged 2 commits intosimdutf:masterfrom leezaj:support-char8_t
pauldreik merged 2 commits intosimdutf:masterfrom
leezaj:support-char8_t
Conversation
Collaborator
|
Thanks for the fix! I think it looks good. I am however not sure if we should guard it with the __cpp_lib_char8_t feature macro? I lean towards merging it as is (provided the CI tests go through). |
Collaborator
|
All the tests go through. Let's merge it and if there are any problems, we fix them later. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
char8_tas a byte-like type, which in turn enables C++20std::u8stringandstd::u8string_view(aliases forstd::basic_string<char8_t>andstd::basic_string_view<char8_t>) objects to be passed in as spans. Right now, simdutf fails to compile if users pass these objects.cppreference states (emphasis mine):
This is enabled in >=C++20 only, and it won't affect older versions.