Merged
Conversation
anonrig
changed the title
pauldreik
reviewed
Dec 5, 2025
|
|
||
| while (buf < end - 16) { | ||
| // Optimized: Process 32 values (2x 512-bit) per iteration for better throughput | ||
| while (buf + 32 <= end) { |
Collaborator
There was a problem hiding this comment.
I think this has to be written end-buf>=32 to avoid UB. (not introduced in this PR)
| } | ||
|
|
||
| // Handle remaining 16-31 values | ||
| if (buf + 16 <= end) { |
lemire
approved these changes
Dec 5, 2025
Member
lemire
left a comment
lemire
left a comment
There was a problem hiding this comment.
Do consider @pauldreik's idea.
The reason it is a bad to do 'mypointer + 32' is that the resulting pointer could be too far.
In C and C++, pointer arithmetic is only defined within the bounds of a single object or array. Specifically: If mypointer points to an element inside an array (or to a standalone object), you are allowed to perform pointer arithmetic as long as the resulting pointer still points into the same array or one past the last element of that array.
(Last paragraph is AI generated.)
I keep messing this up.
Member
|
I'll merge and fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local benchmarks