optimize utf8_length_from_latin1 for short strings#499
Merged
Conversation
Member
Author
|
cc @ronag |
ronag
approved these changes
Aug 13, 2024
Collaborator
|
I'm not sure how to read those bench results? WHat's before and after? |
ronag
reviewed
Aug 13, 2024
ronag
reviewed
Aug 13, 2024
ronag
reviewed
Aug 13, 2024
ronag
reviewed
Aug 13, 2024
ronag
reviewed
Aug 13, 2024
ronag
reviewed
Aug 13, 2024
Co-authored-by: Robert Nagy <[email protected]>
Co-authored-by: Robert Nagy <[email protected]>
Member
Author
The reference is |
Co-authored-by: Robert Nagy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this UTF8 short file:
https://github.com/lemire/unicode_lipsum/tree/main/short
Run the benchmark...
GCC 12, Intel Ice Lake:
LLVM 16, Apple Silicon M2:
See nodejs/node#54345