Skip to content

Fixing support for Windows ARM64#217

Merged
lemire merged 1 commit intomasterfrom
dlemire/issue216
Feb 23, 2023
Merged

Fixing support for Windows ARM64#217
lemire merged 1 commit intomasterfrom
dlemire/issue216

Conversation

@lemire
Copy link
Copy Markdown
Member

@lemire lemire commented Feb 22, 2023

@StefanStojanovic could you test/review?

Capture d’écran, le 2023-02-22 à 16 49 07

Capture d’écran, le 2023-02-22 à 16 49 45

Fixes #216

@StefanStojanovic
Copy link
Copy Markdown

@lemire I'm still experiencing the same behavior from #216, but I also saw that all checks from your CI passed.

From what I can tell, the biggest difference between our runs is that I'm using VS16 (VS 2019) while you are using VS17 (VS 2022). Could you try building and running tests with VS16 and see what happens? The thing here is that in Node.js CI we're using VS 2019 for building on Windows.

FYI, I'm OOF for the rest of the week, but I'll try to follow this as time allows.

@lemire
Copy link
Copy Markdown
Member Author

lemire commented Feb 23, 2023

Ok. Let me try with an older Visual Studio.

@lemire
Copy link
Copy Markdown
Member Author

lemire commented Feb 23, 2023

@StefanStojanovic Ok. Older Visual Studios are not supported on ARM64 and requires cross-compiling.

Checking the cross-compilation.

@lemire
Copy link
Copy Markdown
Member Author

lemire commented Feb 23, 2023

So here is what I did. I went on an x64 machine. I made use that I had both VS 2019 and VS 2022 installed. I then cross-compiled the project.

cmake -G "Visual Studio 16 2019" -A ARM64  -DCMAKE_CROSSCOMPILING=1 -B buildarmold
cmake --build buildarmold

(If you want the more recent Visual Studio, you have to use "Visual Studio 17 2022" instead.)

It built various files. I tend uploaded the files to my ARM64 machine and I ran the files, and they ran fine.

You can download the files in question from my Google Drive...

https://drive.google.com/drive/folders/123o3hC2Ws-_cY_AuPyUHH8CuxCxouZ_F?usp=share_link

@lemire lemire merged commit 871667a into master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Windows on ARM support

2 participants